feat: make it possible to remove workflow runs (#12478)
Add the ability to remove workflow runs, either using the UI or the HTTP API. Workflow runs can only be removed once a workflow run has completed. For security reasons, only a repository administrator or a token with `write:repository` permissions can remove runs. Resolves https://codeberg.org/forgejo/forgejo/issues/2184. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes (can be removed for JavaScript changes) - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Tests for JavaScript changes (can be removed for Go changes) - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. *The decision if the pull request will be shown in the release notes is up to the mergers / release team.* The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Features - [PR](https://codeberg.org/forgejo/forgejo/pulls/12478): <!--number 12478 --><!--line 0 --><!--description bWFrZSBpdCBwb3NzaWJsZSB0byByZW1vdmUgd29ya2Zsb3cgcnVucw==-->make it possible to remove workflow runs<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12478 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
This commit is contained in:
committed by
Mathieu Fenniak
parent
2d5dd62cf3
commit
03312e4f46
@@ -6,6 +6,8 @@ const testLocale = {
|
||||
approve: 'Locale Approve',
|
||||
cancel: 'Locale Cancel',
|
||||
rerun: 'Locale Re-run',
|
||||
delete: 'Locale Delete',
|
||||
confirmDelete: '',
|
||||
artifactsTitle: 'artifactTitleHere',
|
||||
areYouSure: '',
|
||||
confirmDeleteArtifact: '',
|
||||
@@ -168,6 +170,7 @@ function configureForMultipleAttemptTests({viewHistorical}) {
|
||||
canApprove: true,
|
||||
canCancel: true,
|
||||
canRerun: true,
|
||||
canDelete: false,
|
||||
status: 'success',
|
||||
commit: {
|
||||
pusher: {},
|
||||
|
||||
@@ -4,6 +4,7 @@ import ActionRunStatus from './ActionRunStatus.vue';
|
||||
import ActionJobStepList from './ActionJobStepList.vue';
|
||||
import {toggleElem} from '../utils/dom.js';
|
||||
import {GET, POST, DELETE} from '../modules/fetch.js';
|
||||
import {showErrorToast} from '../modules/toast.js';
|
||||
|
||||
export default {
|
||||
name: 'RepoActionView',
|
||||
@@ -86,6 +87,7 @@ export default {
|
||||
canCancel: false,
|
||||
canApprove: false,
|
||||
canRerun: false,
|
||||
canDelete: false,
|
||||
done: false,
|
||||
preExecutionError: '',
|
||||
jobs: [
|
||||
@@ -237,6 +239,21 @@ export default {
|
||||
}
|
||||
},
|
||||
|
||||
async deleteRun() {
|
||||
if (!window.confirm(this.locale.confirmDelete)) {
|
||||
return;
|
||||
}
|
||||
|
||||
const response = await POST(`${this.run.link}/delete`);
|
||||
|
||||
if (response.ok) {
|
||||
window.location.href = this.workflowURL;
|
||||
return;
|
||||
}
|
||||
|
||||
showErrorToast(this.locale.deleteError, {duration: 5000});
|
||||
},
|
||||
|
||||
// cancel a run
|
||||
cancelRun() {
|
||||
POST(`${this.run.link}/cancel`);
|
||||
@@ -474,6 +491,9 @@ export default {
|
||||
{{ locale.approve }}
|
||||
</button>
|
||||
<div class="action-info-summary-actions" v-else>
|
||||
<button id="delete-run" class="ui basic small compact button red" @click="deleteRun()" v-if="run.canDelete">
|
||||
{{ locale.delete }}
|
||||
</button>
|
||||
<button class="ui basic small compact button red" @click="cancelRun()" v-if="canCancel">
|
||||
{{ locale.cancel }}
|
||||
</button>
|
||||
|
||||
@@ -29,6 +29,9 @@ export async function initRepositoryActionView() {
|
||||
approve: el.getAttribute('data-locale-approve'),
|
||||
cancel: el.getAttribute('data-locale-cancel'),
|
||||
rerun: el.getAttribute('data-locale-rerun'),
|
||||
delete: el.getAttribute('data-locale-delete'),
|
||||
confirmDelete: el.getAttribute('data-locale-confirm-delete'),
|
||||
deleteError: el.getAttribute('data-locale-delete-error'),
|
||||
artifactsTitle: el.getAttribute('data-locale-artifacts-title'),
|
||||
areYouSure: el.getAttribute('data-locale-are-you-sure'),
|
||||
confirmDeleteArtifact: el.getAttribute('data-locale-confirm-delete-artifact'),
|
||||
|
||||
Reference in New Issue
Block a user