fix(actions): replace hardcoded with dynamically determined workflow directory (#10411)

When manually triggering a Forgejo Actions workflow, Forgejo always assumed the workflow directory to be `.forgejo/workflows`, even if the workflows were found in `.gitea/workflows` or `.github/workflows`. As a consequence, the executed workflows were misidentified in the UI. Furthermore, the context variable `${{ forgejo.workflow_ref }}`, which contains the full path to the workflow file, pointed to a non-existent file. The workflow directory is now determined dynamically. Existing database entries are left unmodified.

The screenshot shows the old behaviour for run 3 and the new, correct behaviour for run 4.

![workflow-dispatch](/attachments/563557a5-9cff-4c81-aec3-ffb18c831b52)

The PR is marked as WIP because it requires https://codeberg.org/forgejo/forgejo/pulls/10276 to be merged first.

## Checklist

The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).

### Tests

- I added test coverage for Go changes...
  - [x] in their respective `*_test.go` for unit tests.
  - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
  - [ ] in `web_src/js/*.test.js` if it can be unit tested.
  - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).

### Documentation

- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [ ] I do not want this change to show in the release notes.
- [ ] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.

<!--start release-notes-assistant-->

## Release notes
<!--URL:https://codeberg.org/forgejo/forgejo-->
- Bug fixes
  - [PR](https://codeberg.org/forgejo/forgejo/pulls/10411): <!--number 10411 --><!--line 0 --><!--description Zml4KGFjdGlvbnMpOiByZXBsYWNlIGhhcmRjb2RlZCB3aXRoIGR5bmFtaWNhbGx5IGRldGVybWluZWQgd29ya2Zsb3cgZGlyZWN0b3J5-->fix(actions): replace hardcoded with dynamically determined workflow directory<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10411
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
Reviewed-by: Cyborus <cyborus@disroot.org>
Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>

services/actions/workflows.go

@@ -41,10 +41,11 @@ func IsInputRequiredErr(err error) bool {
 }
 
 type Workflow struct {
-	WorkflowID string
-	Ref        string
-	Commit     *git.Commit
-	GitEntry   *git.TreeEntry
+	WorkflowDirectory string
+	WorkflowID        string
+	Ref               string
+	Commit            *git.Commit
+	GitEntry          *git.TreeEntry
 }
 
 type InputValueGetter func(key string) string
@@ -74,6 +75,10 @@ func resolveDispatchInput(key, value string, input act_model.WorkflowDispatchInp
 	return value, nil
 }
 
+func (entry *Workflow) WorkflowPath() string {
+	return entry.WorkflowDirectory + "/" + entry.WorkflowID
+}
+
 func (entry *Workflow) Dispatch(ctx context.Context, inputGetter InputValueGetter, repo *repo_model.Repository, doer *user.User) (r *actions_model.ActionRun, j []string, err error) {
 	content, err := actions.GetContentFromEntry(entry.GitEntry)
 	if err != nil {
@@ -85,7 +90,7 @@ func (entry *Workflow) Dispatch(ctx context.Context, inputGetter InputValueGette
 		return nil, nil, err
 	}
 
-	fullWorkflowID := ".forgejo/workflows/" + entry.WorkflowID
+	fullWorkflowID := entry.WorkflowPath()
 
 	title := wf.Name
 	if len(title) < 1 {
@@ -137,7 +142,7 @@ func (entry *Workflow) Dispatch(ctx context.Context, inputGetter InputValueGette
 		Repo:              repo,
 		OwnerID:           repo.OwnerID,
 		WorkflowID:        entry.WorkflowID,
-		WorkflowDirectory: ".forgejo/workflows",
+		WorkflowDirectory: entry.WorkflowDirectory,
 		TriggerUserID:     doer.ID,
 		TriggerUser:       doer,
 		Ref:               entry.Ref,
@@ -199,7 +204,7 @@ func GetWorkflowFromCommit(gitRepo *git.Repository, ref, workflowID string) (*Wo
 		return nil, err
 	}
 
-	_, entries, err := actions.ListWorkflows(commit)
+	workflowDirectory, entries, err := actions.ListWorkflows(commit)
 	if err != nil {
 		return nil, err
 	}
@@ -216,10 +221,11 @@ func GetWorkflowFromCommit(gitRepo *git.Repository, ref, workflowID string) (*Wo
 	}
 
 	return &Workflow{
-		WorkflowID: workflowID,
-		Ref:        ref,
-		Commit:     commit,
-		GitEntry:   workflowEntry,
+		WorkflowDirectory: workflowDirectory,
+		WorkflowID:        workflowID,
+		Ref:               ref,
+		Commit:            commit,
+		GitEntry:          workflowEntry,
 	}, nil
 }