CloudsandGusted 044f3d95b6 chore: re-enable nilnil lint for models/actions/task.go (#12768) ...

I added sentinel error values for jobs not being found and no jobs being updated by the `CreateTaskForRunner` function. This avoids the nilnil antipattern and allows the nilnil lint to be enabled for the `models/actions/task.go` file again.

The handling of these new errors was added to the `PickTask` function in `services/actions/task.go`.

Related issue: https://codeberg.org/forgejo/forgejo/issues/11261

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12768
Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org>
Reviewed-by: elle <0xllx0@noreply.codeberg.org>

2026-06-05 01:38:23 +02:00

..

Test_checkJobsOfRun

fix: update statuses in phases to prevent out of order updates from stalling workflows (#12685)

2026-05-25 05:20:23 +02:00

Test_tryHandleIncompleteMatrix

fix: empty dynamic matrix can leave action run hanging incomplete (#11063)

2026-01-27 17:10:59 +01:00

Test_tryHandleWorkflowCallOuterJob

fix: superfluous increment of ActionTask attempt breaks job view (#11956)

2026-04-03 16:05:09 +02:00

TestActions_CancelOrApproveRun

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

TestActions_consistencyCheckRun

fix: prevent jobs with unknown needs from running (#12046)

2026-04-10 15:40:08 +02:00

TestActionsNotifier_IsTrusted

chore(refactor): replace ifNeedApproval with trust management

2025-11-06 11:07:39 +01:00

TestActionsTrust_GetPullRequestUserIsTrustedWithActions

feat: trust management for runs created from a forked pull request

2025-11-06 11:07:38 +01:00

TestCancelAbandonedJobs

fix: don't abandon Action jobs waiting for approval (#11145)

2026-02-04 16:00:18 +01:00

TestCancelPreviousJobs

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

TestCancelPreviousWithConcurrencyGroup

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

TestCreateCommitStatus

fix: don't duplicate commit status records on workflows with empty name (#10678)

2026-01-02 19:02:10 +01:00

TestDeleteJobsOfRun

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

TestDeleteRun

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

TestDeleteTask

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

TestExpandLocalReusableWorkflows

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

TestGetSecretsOfJob

feat: support jobs.<job_id>.secrets with reusable workflow expansion (#10627)

2025-12-30 17:33:21 +01:00

TestRerun_RerunAllJobs

fix: wipe run artifacts before rerun (#12523)

2026-05-11 21:45:56 +02:00

TestRerun_RerunJob

fix: keep run in sync when rerunning individual jobs (#12818)

2026-05-29 22:26:46 +02:00

TestServiceActions_startTask

feat: support timezone in scheduled workflows (#11851)

2026-04-04 18:23:06 +02:00

TestServicesActions_TransferLingeringLogs

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

auth_test.go

feat: expose immutable identifiers in Forgejo Actions JWTs (#12355)

2026-05-03 15:46:58 +02:00

auth.go

feat: expose immutable identifiers in Forgejo Actions JWTs (#12355)

2026-05-03 15:46:58 +02:00

cleanup_test.go

feat: implement ephemeral runners (#9962)

2026-02-16 18:56:56 +01:00

cleanup.go

feat: implement ephemeral runners (#9962)

2026-02-16 18:56:56 +01:00

clear_tasks_test.go

fix: don't abandon Action jobs waiting for approval (#11145)

2026-02-04 16:00:18 +01:00

clear_tasks.go

Revert "fix: ensure actions logs are transferred when a task is done (#10008)" (#11462)

2026-03-02 15:34:09 +01:00

commit_status_test.go

fix: retain Forgejo Action's commit_status entries with distinct descriptions (#10696)

2026-01-05 14:47:27 +01:00

commit_status.go

feat: mark skipped checks as skipped (#12606)

2026-05-17 18:00:49 +02:00

context_test.go

feat: expose immutable identifiers in Forgejo Actions JWTs (#12355)

2026-05-03 15:46:58 +02:00

context.go

feat: expose immutable identifiers in Forgejo Actions JWTs (#12355)

2026-05-03 15:46:58 +02:00

download.go

chore: make use of go1.26 features (#12369)

2026-05-01 22:51:48 +02:00

init.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

interface.go

feat: add HTTP API endpoint for runner registration (#10677)

2026-01-05 04:59:04 +01:00

job_emitter_test.go

fix: update statuses in phases to prevent out of order updates from stalling workflows (#12685)

2026-05-25 05:20:23 +02:00

job_emitter.go

fix: update statuses in phases to prevent out of order updates from stalling workflows (#12685)

2026-05-25 05:20:23 +02:00

job_logs_test.go

feat(api): expose action job + run logs via REST (#12666)

2026-05-30 01:45:32 +02:00

job_logs.go

feat(api): expose action job + run logs via REST (#12666)

2026-05-30 01:45:32 +02:00

job_test.go

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

job.go

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

log_test.go

chore: fix typos throughout the codebase (#10753)

2026-01-26 22:57:33 +01:00

log.go

fix: garbage collect lingering actions logs (#10009)

2025-11-18 18:59:01 +01:00

main_test.go

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

notifier_helper_test.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

notifier_helper.go

feat: support timezone in scheduled workflows (#11851)

2026-04-04 18:23:06 +02:00

notifier.go

fix: cancel runs pending approval when a PR is closed (#11134)

2026-02-02 23:20:41 +01:00

rerun_test.go

fix: keep run in sync when rerunning individual jobs (#12818)

2026-05-29 22:26:46 +02:00

rerun.go

fix: keep run in sync when rerunning individual jobs (#12818)

2026-05-29 22:26:46 +02:00

reusable_workflows_test.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

reusable_workflows.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

run_test.go

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

run.go

fix: cancel dependent jobs when rerunning jobs (#12756)

2026-05-29 04:46:57 +02:00

schedule_tasks_test.go

feat: support timezone in scheduled workflows (#11851)

2026-04-04 18:23:06 +02:00

schedule_tasks.go

fix: in actions_service cancelJobsForRun is bugous use killRun instead (#12366)

2026-05-09 04:46:56 +02:00

secret_test.go

feat: support jobs.<job_id>.secrets with reusable workflow expansion (#10627)

2025-12-30 17:33:21 +01:00

secret.go

feat: support jobs.<job_id>.secrets with reusable workflow expansion (#10627)

2025-12-30 17:33:21 +01:00

task_test.go

feat: make it possible to remove workflow runs (#12478)

2026-05-11 16:02:36 +02:00

task.go

chore: re-enable nilnil lint for models/actions/task.go (#12768)

2026-06-05 01:38:23 +02:00

trust_test.go

fix: cancel runs pending approval when a PR is closed (#11134)

2026-02-02 23:20:41 +01:00

trust.go

fix: cancel runs pending approval when a PR is closed (#11134)

2026-02-02 23:20:41 +01:00

variables_test.go

fix: allow Forgejo Actions environment variables starting with CI (#8850)

2025-08-10 22:56:16 +02:00

variables.go

feat: allow renaming and replacing secrets (#11732)

2026-03-23 03:30:02 +01:00

workflows_test.go

Update module code.forgejo.org/forgejo/runner/v11 to v12 (forgejo) (#10213)

2025-11-23 15:58:57 +01:00

workflows.go

fix: handle boolean workflow inputs correctly before jobparser evaluates with them (#12539)

2026-05-12 22:41:07 +02:00