I added sentinel error values for jobs not being found and no jobs being updated by the `CreateTaskForRunner` function. This avoids the nilnil antipattern and allows the nilnil lint to be enabled for the `models/actions/task.go` file again. The handling of these new errors was added to the `PickTask` function in `services/actions/task.go`. Related issue: https://codeberg.org/forgejo/forgejo/issues/11261 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12768 Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org> Reviewed-by: elle <0xllx0@noreply.codeberg.org>
19 lines
364 B
YAML
19 lines
364 B
YAML
-
|
|
id: 1000
|
|
run_id: 900
|
|
repo_id: 4
|
|
owner_id: 1
|
|
name: "crate task - no job updated test job"
|
|
job_id: create_task_no_job_updated
|
|
task_id: 0
|
|
status: 5 # StatusWaiting
|
|
runs_on: '["ubuntu"]'
|
|
workflow_payload: |
|
|
name: test
|
|
on: push
|
|
jobs:
|
|
concurrent_test_job:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo hello
|