Mathieu FenniakandMathieu Fenniak
29eddd311b
Upgrade Forgejo to our forked [xorm v1.4.0](https://code.forgejo.org/xorm/xorm/compare/v1.3.9-forgejo.12...v1.4.0), which is now named `code.forgejo.org/xorm/xorm` to reflect the current expectation that it is a permanent fork. A small number of API changes were made recently in https://code.forgejo.org/xorm/xorm/issues/120 which are accounted for in this PR, in addition to the module rename. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12639 Reviewed-by: Otto <otto@codeberg.org>
82 lines
2.2 KiB
Go
82 lines
2.2 KiB
Go
// Copyright 2023 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package forgejo_migrations_legacy
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migration_tests "forgejo.org/models/gitea_migrations/test"
|
|
"forgejo.org/modules/test"
|
|
|
|
"code.forgejo.org/xorm/xorm"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestEnsureUpToDate tests the behavior of EnsureUpToDate.
|
|
func TestEnsureUpToDate(t *testing.T) {
|
|
defer test.MockVariableValue(&forgejoMigrationsEnsureUpToDate, func(x *xorm.Engine) error {
|
|
return nil
|
|
})()
|
|
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(ForgejoVersion))
|
|
defer deferable()
|
|
if x == nil || t.Failed() {
|
|
return
|
|
}
|
|
|
|
// Ensure error if there's no row in Forgejo Version.
|
|
err := EnsureUpToDate(x)
|
|
require.Error(t, err)
|
|
|
|
// Insert 'good' Forgejo Version row.
|
|
_, err = x.Insert(&ForgejoVersion{ID: 1, Version: ExpectedVersion()})
|
|
require.NoError(t, err)
|
|
|
|
err = EnsureUpToDate(x)
|
|
require.NoError(t, err)
|
|
|
|
// Modify forgejo version to have a lower version.
|
|
_, err = x.Exec("UPDATE `forgejo_version` SET version = ? WHERE id = 1", ExpectedVersion()-1)
|
|
require.NoError(t, err)
|
|
|
|
err = EnsureUpToDate(x)
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestMigrateFreshDB(t *testing.T) {
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(ForgejoVersion))
|
|
defer deferable()
|
|
require.NotNil(t, x)
|
|
|
|
err := Migrate(x)
|
|
require.NoError(t, err)
|
|
|
|
var versionRecords []*ForgejoVersion
|
|
err = x.Find(&versionRecords)
|
|
require.NoError(t, err)
|
|
require.Len(t, versionRecords, 1)
|
|
v := versionRecords[0]
|
|
assert.EqualValues(t, 1, v.ID)
|
|
assert.EqualValues(t, 44, v.Version)
|
|
}
|
|
|
|
func TestMigrateFailWithCorruption(t *testing.T) {
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(ForgejoVersion))
|
|
defer deferable()
|
|
require.NotNil(t, x)
|
|
|
|
// ID != 1
|
|
_, err := x.Insert(&ForgejoVersion{ID: 100, Version: 100})
|
|
require.NoError(t, err)
|
|
err = Migrate(x)
|
|
require.ErrorContains(t, err, "corrupted records in the table `forgejo_version`")
|
|
|
|
// Two versions...
|
|
_, err = x.Insert(&ForgejoVersion{ID: 1, Version: 1000})
|
|
require.NoError(t, err)
|
|
err = Migrate(x)
|
|
require.ErrorContains(t, err, "unexpected records in the table `forgejo_version`")
|
|
}
|