silverwindandEarl Warren 12b199c5e5 Enable more revive linter rules (#30608) ...

Noteable additions:

- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches

Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.

(cherry picked from commit 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2)

Conflicts:
	.golangci.yml
	apply the linter recommendations to Forgejo code as well

2024-04-28 15:39:00 +02:00

..

actions

Merge pull request '[ACTIONS] port scheduled actions from Gitea' (#2826) from earl-warren/forgejo:wip-gitea-schedule into forgejo

2024-03-27 06:23:56 +00:00

activitypub

Upgrade to golangci-lint@v1.55.0 (#27756)

2023-10-24 02:54:59 +00:00

analyze

Rename code_langauge.go to code_language.go (#26377)

2023-08-07 15:00:53 -04:00

assetfs

Use Set[Type] instead of map[Type]bool/struct{}. (#26804)

2023-08-30 06:55:25 +00:00

auth

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

avatar

[GITEA] Drop sha256-simd in favor of stdlib

2024-02-05 16:09:40 +01:00

base

Refactor StringsToInt64s (#29967)

2024-03-26 19:04:26 +01:00

cache

Always enable caches (#28527)

2023-12-19 09:29:05 +00:00

charset

s/Gitea/Forgejo in various log messages and comments

2024-04-21 21:26:15 +05:00

container

Add container.FilterSlice function (gitea#30339)

2024-04-16 11:49:44 +02:00

csv

Refactor locale&string&template related code (#29165)

2024-02-16 15:20:52 +01:00

emoji

Update emoji set to Unicode 15 (#25595)

2023-06-29 16:29:48 +00:00

eventsource

Final round of db.DefaultContext refactor (#27587)

2023-10-14 08:37:24 +00:00

generate

Port "Use general token signing secret"

2024-02-19 20:49:37 +01:00

git

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

gitgraph

models/asymkey: Implement Tag verification

2024-03-30 16:22:05 +01:00

gitrepo

Move get/set default branch from git package to gitrepo package to hide repopath (#29126)

2024-03-11 23:36:59 +07:00

graceful

[FIX] make pprof labels conformant with prometheus spec

2024-03-31 17:07:14 +02:00

hcaptcha

Consume hcaptcha and pwn deps (#22610)

2023-01-29 09:49:51 -06:00

highlight

Fix

2024-03-30 15:23:48 +01:00

hostmatcher

Support allowed hosts for webhook to work with proxy (#27655)

2023-10-18 09:44:36 +00:00

html

Refactor backend SVG package and add tests (#26335)

2023-08-05 04:34:59 +00:00

httpcache

[BRANDING] add X-Forgejo-* headers

2024-02-05 16:02:14 +01:00

httplib

[PORT] drop utils.IsExternalURL (and expand IsRiskyRedirectURL tests) (#3167)

2024-04-15 13:03:08 +00:00

indexer

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

issue/template

Extend issue template yaml engine (#29274)

2024-03-06 12:10:47 +08:00

json

Replace interface{} with any (#25686)

2023-07-04 18:36:08 +00:00

label

Make label templates have consistent behavior and priority (#23749)

2023-04-10 16:44:02 +08:00

lfs

fix: close file in the Upload func (#30262)

2024-04-07 15:40:31 +02:00

log

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

markup

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

mcaptcha

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

metrics

Reduce usage of db.DefaultContext (#27073)

2023-09-14 17:09:32 +00:00

migration

Refactor locale&string&template related code (#29165)

2024-02-16 15:20:52 +01:00

nosql

s/Gitea/Forgejo in various log messages and comments

2024-04-21 21:26:15 +05:00

optional

Add interface{} to any replacement to make fmt, exclude *.pb.go (#30461)

2024-04-15 20:01:36 +02:00

options

Use a general approach to access custom/static/builtin assets (#24022)

2023-04-12 18:16:45 +08:00

packages

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

paginator

Use more specific test methods (#24265)

2023-04-22 17:56:27 -04:00

pprof

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

private

[CLI] implement forgejo-cli

2024-02-05 13:33:58 +01:00

process

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

proxy

Use proxy for pull mirror (#22771)

2023-02-11 08:39:50 +08:00

proxyprotocol

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

public

Refactor CORS handler (#28587)

2023-12-25 20:13:18 +08:00

queue

workergroup: gracefully exit on close(popItemErr)

2024-03-24 07:12:31 +01:00

recaptcha

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

references

Fix issue link does not support quotes (#29484) (#29487)

2024-03-06 12:10:45 +08:00

regexplru

Upgrade go dependencies (#25819)

2023-07-14 11:00:31 +08:00

repository

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

secret

[GITEA] Drop sha256-simd in favor of stdlib

2024-02-05 16:09:40 +01:00

session

Avoid importing modules/web/middleware in modules/session (#30584)

2024-04-21 16:28:16 +02:00

setting

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

sitemap

Fix sitemap (#22272)

2022-12-30 23:31:00 +08:00

ssh

Remove SSH workaround (#27893)

2023-11-03 15:21:05 +00:00

storage

Add minio bucket lookup type option

2024-03-06 09:38:02 +00:00

structs

[FEAT]Add Option to hide Release Archive links (#3139)

2024-04-24 15:15:55 +00:00

svg

Refactor backend SVG package and add tests (#26335)

2023-08-05 04:34:59 +00:00

sync

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

system

Replace more db.DefaultContext (#27628)

2023-10-15 17:46:06 +02:00

templates

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

test

[TESTS] add log.Level to test.NewLogChecker

2024-02-05 16:54:44 +01:00

testlogger

Merge pull request '[FEAT] Mark database errors in tests as failure' (#2972) from gusted/forgejo-log-db into forgejo

2024-04-02 14:47:32 +00:00

timeutil

Remove the time-since class (#29826)

2024-03-20 08:46:30 +01:00

translation

Rename ByteSize to ReadableSize

2024-03-31 20:17:12 +05:00

turnstile

Add new captcha: cloudflare turnstile (#22369)

2023-02-05 15:29:03 +08:00

typesniffer

Detect ogg mime-type as audio or video (#26494)

2023-08-15 10:31:25 +08:00

updatechecker

[PRIVACY] Add a DNS method to fetch new updates

2024-02-05 15:38:36 +01:00

uri

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

user

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

util

Enable more revive linter rules (#30608)

2024-04-28 15:39:00 +02:00

validation

[GITEA] add option for banning dots in usernames

2024-02-05 16:05:50 +01:00

web

Avoid importing modules/web/middleware in modules/session (#30584)

2024-04-21 16:28:16 +02:00

webhook

[FEAT] sourcehut webhooks

2024-04-05 10:20:40 +02:00