Oliver EikemeierandGusted 757eb2f267 chore: handle error types consistently (#9873) ...

Some error types are used inconsistently or wrong:

- `forgejo.org/modules/git.ErrNotExist` is meant to be a value error: <[modules/git/error.go#L23](https://codeberg.org/forgejo/forgejo/src/tag/v13.0.2/modules/git/error.go#L23)>

- `forgejo.org/models/repo.ErrRepoNotExist` is meant to be a value error: <[models/repo/repo.go#L750](https://codeberg.org/forgejo/forgejo/src/tag/v13.0.2/models/repo/repo.go#L750)>

- `errors.Is(logErr, &net.OpError{})` is always `false`: <[services/context/context_response.go#L188](https://codeberg.org/forgejo/forgejo/src/tag/v13.0.2/services/context/context_response.go#L188)>

- `forgejo.org/models/issues.ErrIssueContentHistoryNotExist` is used inconsistently: <[models/issues/content_history.go#L211](https://codeberg.org/forgejo/forgejo/src/tag/v13.0.2/models/issues/content_history.go#L211)>
Decided to use a value, since the structure is small and to be in line with the above errors.

These issued where found with the [errortype](https://codeberg.org/fillmore-labs/errortype) linter and add this to Makefile as part of the linter suite.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9873
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Co-committed-by: Oliver Eikemeier <eikemeier@fillmore-labs.com>

2026-03-06 00:48:06 +01:00

..

color_console_other.go

chore: handle error types consistently (#9873)

2026-03-06 00:48:06 +01:00

color_console.go

log: journald integration (#2869)

2024-08-09 07:49:13 +00:00

color_router.go

Rewrite logger system (#24726)

2023-05-21 22:35:11 +00:00

color.go

Rewrite logger system (#24726)

2023-05-21 22:35:11 +00:00

event_format_test.go

chore: remove goroutine PID logging (#8851)

2025-08-10 22:54:29 +02:00

event_format.go

chore: remove goroutine PID logging (#8851)

2025-08-10 22:54:29 +02:00

event_writer_base.go

feat: add a EXCLUSION to the logger (#8212)

2025-07-04 00:08:23 +02:00

event_writer_buffer_test.go

feat: add a EXCLUSION to the logger (#8212)

2025-07-04 00:08:23 +02:00

event_writer_buffer.go

feat: add a buffer writer to the logger, for internal use (#6551)

2025-01-13 13:40:24 +00:00

event_writer_conn_test.go

Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v1.64.6 (forgejo) (#7118)

2025-03-04 21:38:35 +00:00

event_writer_conn.go

Rewrite logger system (#24726)

2023-05-21 22:35:11 +00:00

event_writer_console.go

Rewrite logger system (#24726)

2023-05-21 22:35:11 +00:00

event_writer_file.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

event_writer.go

feat: add a EXCLUSION to the logger (#8212)

2025-07-04 00:08:23 +02:00

flags_test.go

chore: remove goroutine PID logging (#8851)

2025-08-10 22:54:29 +02:00

flags.go

chore: remove goroutine PID logging (#8851)

2025-08-10 22:54:29 +02:00

init.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

level_test.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

level.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

logger_global.go

Fix sub-command log level (#25537)

2023-06-28 08:02:06 +02:00

logger_impl_test.go

fix: correct logging if caller has generics

2025-03-05 00:10:46 +01:00

logger_impl.go

chore: remove goroutine PID logging (#8851)

2025-08-10 22:54:29 +02:00

logger_test.go

feat: add a EXCLUSION to the logger (#8212)

2025-07-04 00:08:23 +02:00

logger.go

Rewrite logger system (#24726)

2023-05-21 22:35:11 +00:00

manager_test.go

Add testifylint to lint checks (#4535)

2024-07-30 19:41:10 +00:00

manager.go

Do not output "Trace" level logs from process manager by default (#24952)

2023-05-27 10:55:24 +00:00

misc.go

Rewrite logger system (#24726)

2023-05-21 22:35:11 +00:00

stack.go

feat(log): better parseable and configurable ssh-logs (#9056)

2025-09-11 18:59:24 +02:00