Thomas Kolar and Gusted 6132d0e406
fix: Prevent unremovable review requests after submitting pending reviews ( #12302 ) ...
Some notes:
- I didn't write integration tests because it's a pure bugfix that addresses implementation details of the model layer.
- I can see interpretations of "it involves interactions with a live Forgejo server" that would cover this PR, but they don't make sense to me in context.
- I didn't add anything to the documentation because it's a pure bugfix - the system should always have worked this way
- there's no value in confusing people trying to figure out how the system works now with how it didn't work in the past
- However, there IS value in informing people who may have gotten bitten by this in the past, so I think a release note makes sense
- These fixes are closely related, and the changes small, so I decided to make just one PR.
- From a user perspective, this is just one issue, and I think in terms of release notes, it makes more sense to have just this one.
- Technically, fixing only one of the underlying issues would be enough. Since this is a case of invalid states being representable, it makes sense to both try to prevent it happening in the first place, and deal with it gracefully if it does happen.
- At the very least, fixing #12245 is required unless we want to live with data generated in the past being broken
Fixes #12243
Fixes #12245
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12302
Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org >
2026-05-08 05:52:59 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-08-08 16:07:35 +00:00
2024-07-15 21:22:56 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2025-10-05 17:10:38 +05:00
2024-07-11 14:20:34 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-08-08 16:07:35 +00:00
2024-07-15 21:22:56 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-10-09 04:56:40 +00:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-07-15 21:22:56 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-08-02 11:10:34 +02:00
2024-07-10 08:52:06 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-11 14:20:34 +02:00
2024-07-10 05:14:16 +00:00
2024-07-10 05:14:16 +00:00
2024-07-11 14:20:34 +02:00
2024-07-09 08:24:46 +02:00
2024-07-11 14:20:34 +02:00
2024-08-18 17:04:00 +02:00
2024-07-15 17:27:37 +02:00
2024-07-17 14:52:00 +02:00
2024-07-23 18:47:42 +02:00
2024-07-21 13:01:08 +05:00
2024-07-22 15:46:01 +02:00
2024-07-23 18:31:47 +02:00
2024-08-22 09:09:29 +02:00
2024-07-28 09:00:29 +02:00
2024-08-08 06:32:14 +00:00
2024-08-04 18:24:10 +02:00
2024-08-22 17:05:07 +02:00
2024-08-13 22:14:46 +01:00
2024-08-13 09:05:50 +02:00
2024-08-12 19:11:09 +02:00
2024-08-19 09:27:37 +02:00
2024-08-23 08:37:00 +02:00
2024-08-25 03:47:08 +02:00
2024-08-26 07:44:20 +02:00
2024-08-26 09:54:03 +02:00
2024-08-28 10:33:32 +02:00
2024-09-01 08:39:30 +02:00
2024-09-14 10:55:08 +02:00
2024-09-20 07:11:08 +02:00
2024-09-27 08:47:23 +02:00
2026-01-09 17:49:29 +01:00
2024-09-29 11:35:18 +02:00
2024-10-04 08:53:11 +02:00
2024-10-06 08:21:41 +02:00
2024-10-10 16:00:16 +03:00
2024-10-13 14:17:08 +03:00
2024-10-18 10:12:06 +02:00
2024-10-22 18:14:27 +02:00
2024-10-26 19:15:43 +02:00
2024-10-27 11:27:40 +01:00
2024-10-28 05:48:10 +01:00
2024-10-28 06:25:52 +01:00
2024-10-31 07:15:14 +01:00
2024-11-04 12:10:15 +01:00
2024-11-05 09:39:24 +01:00
2024-11-15 11:17:14 +01:00
2024-11-16 15:25:37 +01:00
2024-11-18 19:20:54 +01:00
2024-11-24 15:43:19 +00:00
2024-12-03 10:21:20 +01:00
2024-12-08 09:10:58 +01:00
2024-12-15 10:16:04 +01:00
2025-01-23 07:22:05 +00:00
2025-01-01 19:50:39 +01:00
2025-01-05 13:47:27 +00:00
2025-03-05 17:24:51 +00:00
2025-10-05 17:24:51 +05:00
2025-01-21 17:30:08 +00:00
2025-02-02 12:05:46 +01:00
2025-05-25 19:17:03 +02:00
2025-05-03 10:54:52 +00:00
2025-03-17 16:25:37 +00:00
2025-10-05 17:43:06 +05:00
2025-10-05 17:43:06 +05:00
2025-10-05 17:43:06 +05:00
2025-10-05 17:43:06 +05:00
2025-06-01 22:16:37 +02:00
2025-10-05 17:50:35 +05:00
2025-07-23 01:01:31 +02:00
2025-10-05 17:50:35 +05:00
2025-08-27 08:53:20 +02:00
2025-09-19 22:32:06 +02:00
2025-10-01 00:31:38 +02:00
2025-10-08 18:20:28 +02:00
2025-10-07 18:53:57 +02:00
2025-10-13 23:16:17 +02:00
2025-10-29 22:43:22 +01:00
2025-10-26 04:51:04 +01:00
2025-10-26 04:51:04 +01:00
2025-11-09 01:06:04 +01:00
2026-04-12 03:31:03 +02:00
2026-04-27 22:34:46 +02:00
2026-03-19 04:34:27 +01:00
2026-02-07 12:58:26 +01:00
2026-03-02 06:03:39 +01:00
2026-04-21 19:39:33 +02:00
2026-03-03 21:36:14 +01:00
2026-03-10 23:49:18 +01:00
2026-02-28 19:47:06 +01:00
2026-03-01 17:05:53 +01:00
2026-03-01 10:54:43 -07:00
2026-03-08 20:07:52 -06:00
2026-03-08 20:07:52 -06:00
2026-03-17 09:11:52 +01:00
2026-03-20 16:14:36 +01:00
2026-04-30 16:58:28 +02:00
2026-04-29 05:26:22 +02:00
2026-04-29 05:26:22 +02:00
2026-04-29 05:26:22 +02:00
2026-05-08 05:52:59 +02:00
