Michael JergerandEarl Warren
6f501b1fdf
This PR is part of https://codeberg.org/forgejo/forgejo/pulls/4767 It improves the signature handling: 1. move logic to a service (might be used from other services as well) 2. make a clear difference between ` ReqHTTPUserSignature` and `ReqHTTPUserOrInstanceSignature` 3. improve test ability (activitypub/client & distant_federation_server_mock Adjust instance actor 1. name & 2. webfinger ## Strategy for next PRs is Integration tests are in the driving seat. I will step by step add integration tests form original PR and add code required by the integration test changes. ## Meta Proposal howto process large PRs can be discussed here: https://codeberg.org/forgejo-contrib/federation/pulls/37 Current state with rendered diagrams can be found here: https://codeberg.org/meissa/federation/src/branch/merge-large-pr/doc/merge-large-pr.md Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8275 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de> Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
78 lines
2.3 KiB
Go
78 lines
2.3 KiB
Go
// Copyright 2024 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"testing"
|
|
|
|
"forgejo.org/modules/forgefed"
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/test"
|
|
"forgejo.org/routers"
|
|
"forgejo.org/services/contexttest"
|
|
"forgejo.org/services/federation"
|
|
"forgejo.org/tests"
|
|
|
|
ap "github.com/go-ap/activitypub"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestActivityPubActor(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Federation.Enabled, true)()
|
|
defer test.MockVariableValue(&testWebRoutes, routers.NormalRoutes())()
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/activitypub/actor")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
assert.Contains(t, resp.Body.String(), "@context")
|
|
|
|
var actor ap.Actor
|
|
err := actor.UnmarshalJSON(resp.Body.Bytes())
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, ap.ApplicationType, actor.Type)
|
|
assert.Equal(t, "ghost", actor.PreferredUsername.String())
|
|
keyID := actor.GetID().String()
|
|
assert.Regexp(t, "activitypub/actor$", keyID)
|
|
assert.Regexp(t, "activitypub/actor/inbox$", actor.Inbox.GetID().String())
|
|
|
|
pubKey := actor.PublicKey
|
|
assert.NotNil(t, pubKey)
|
|
publicKeyID := keyID + "#main-key"
|
|
assert.Equal(t, pubKey.ID.String(), publicKeyID)
|
|
|
|
pubKeyPem := pubKey.PublicKeyPem
|
|
assert.NotNil(t, pubKeyPem)
|
|
assert.Regexp(t, "^-----BEGIN PUBLIC KEY-----", pubKeyPem)
|
|
}
|
|
|
|
func TestActorNewFromKeyId(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Federation.Enabled, true)()
|
|
defer test.MockVariableValue(&testWebRoutes, routers.NormalRoutes())()
|
|
|
|
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
|
ctx, _ := contexttest.MockAPIContext(t, "/api/v1/activitypub/actor")
|
|
sut, err := federation.NewActorIDFromKeyID(ctx.Base, fmt.Sprintf("%sapi/v1/activitypub/actor#main-key", u))
|
|
require.NoError(t, err)
|
|
|
|
port, err := strconv.ParseUint(u.Port(), 10, 16)
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, forgefed.ActorID{
|
|
ID: "actor",
|
|
HostSchema: "http",
|
|
Path: "api/v1/activitypub",
|
|
Host: setting.Domain,
|
|
HostPort: uint16(port),
|
|
UnvalidatedInput: fmt.Sprintf("http://%s:%d/api/v1/activitypub/actor", setting.Domain, port),
|
|
IsPortSupplemented: false,
|
|
}, sut)
|
|
})
|
|
}
|