Mathieu FenniakandMathieu Fenniak
71623b1ab1
Previously, Forgejo's behaviour for an Actions reusable workflow was to send the entire job to one specific Forgejo Runner based upon its required `runs-on` label, and that single Runner would then read the workflow file and perform all the jobs inside simultaneously, merging their log output into one output (#9768). This PR begins an implementation of expanding reusable workflows into their internal jobs. In this PR, the most basic support is implemented for expanding reusable workflows: - If a `runs-on` field is provided on the workflow, then the legacy behaviour of sending the reusable workflow to a runner is maintained. - If the `runs-on` field is omitted, then the job may be expanded, if: - If the `uses:` is a local path within the repo -- expanded - If the `uses:` is a path to another repo that is on the same Forgejo server -- expanded - If the `uses:` is a fully-qualified URL -- not expanded Because this is an "opt-in" implementation by omitting `runs-on`, and all existing capability is retained, I've **omitted some features** from this PR to make the scope small and manageable for review and testing. These features will be implemented after the initial support is landed: - Workflow input variables - Workflow secrets - Workflow output variables - "Incomplete" workflows which require multiple passes to evaluate -- any job within a reusable workflow where the `with`, `runs-on`, or `strategy.matrix` fields contain an output from another job with `${{ needs... }}` Although this implementation has restrictions with missing features, it is intended to fix #9768. Replaces PR #10448. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). - end-to-end testing: https://code.forgejo.org/forgejo/end-to-end/pulls/1316 ### Documentation - [x] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - https://codeberg.org/forgejo/docs/pulls/1648 - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10525 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
51 lines
1.5 KiB
YAML
51 lines
1.5 KiB
YAML
# Case 600 -- workflow that is not a workflow call outer job
|
|
-
|
|
id: 600
|
|
status: 1 # success
|
|
started: 1683636528
|
|
workflow_payload: |
|
|
"on":
|
|
push:
|
|
jobs:
|
|
produce-artifacts:
|
|
name: produce-artifacts
|
|
runs-on: docker
|
|
steps:
|
|
- run: echo "OK!"
|
|
|
|
# Case w/ action_run_job.id = 601 -- workflow call outer job exercising every available context in the `outputs`. Note
|
|
# that jobparser translates `on.workflow_call.outputs` into the outer job's `job.<job_id>.outputs`, so the available
|
|
# contexts should be considered as those in `on.workflow_call.outputs`.
|
|
-
|
|
id: 601
|
|
run_id: 900
|
|
status: 1 # success
|
|
started: 1683636528
|
|
needs: ["outer-job.inner-job"]
|
|
workflow_payload: |
|
|
"on":
|
|
push:
|
|
jobs:
|
|
outer-job:
|
|
name: outer-job
|
|
if: false
|
|
uses: ./.forgjeo/workflows/reusable.yml
|
|
outputs:
|
|
from_inner_job: ${{ needs['outer-job.inner-job'].outputs.my_output }}
|
|
from_inner_job_result: ${{ needs['outer-job.inner-job'].result }}
|
|
from_forgejo_ctx: ${{ forgejo.ref }}
|
|
from_input_ctx: ${{ inputs.wc_input }}!
|
|
from_vars_repo: ${{ vars.repo_var }}
|
|
from_vars_org: ${{ vars.org_var }}
|
|
from_vars_global: ${{ vars.global_var }}
|
|
__metadata:
|
|
workflow_call_inputs:
|
|
wc_input: 'hello, world'
|
|
workflow_call_id: b5a9f46f1f2513d7777fde50b169d323a6519e349cc175484c947ac315a209ed
|
|
- # inner job of run 601
|
|
id: 602
|
|
run_id: 900
|
|
status: 1 # success
|
|
job_id: outer-job.inner-job
|
|
task_id: 100
|