Mathieu FenniakandMichael Kriese 1aca323acb fix: make concurrency group job cancellation effect runs that are failed (#10863) ...

When an action's job fails, it marks the entire run as failed.  Concurrency group cancellation was only looking for runs that are in a pending state, and therefore after a single job failed in the run, none of the other jobs in the run could be cancelled by a matching cancel-in-progress job.

Raised in https://codeberg.org/Codeberg/Community/issues/2315.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10863
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>

2026-01-16 10:54:01 +01:00

..

Test_tryHandleIncompleteMatrix

feat: support reusable workflow expansion when with or strategy.matrix contains ${{ needs... }} (#10647)

2025-12-31 19:04:35 +01:00

Test_tryHandleWorkflowCallOuterJob

fix: re-running an expanded reusable workflow causes duplicate "attempt 1" job (#10666)

2026-01-02 15:26:11 +01:00

TestActions_CancelOrApproveRun

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

TestActions_consistencyCheckRun

feat(actions): support referencing ${{ needs... }} variables in runs-on (#10308)

2025-12-05 18:14:43 +01:00

TestActionsNotifier_IsTrusted

chore(refactor): replace ifNeedApproval with trust management

2025-11-06 11:07:39 +01:00

TestActionsTrust_GetPullRequestUserIsTrustedWithActions

feat: trust management for runs created from a forked pull request

2025-11-06 11:07:38 +01:00

TestCancelPreviousJobs

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

TestCancelPreviousWithConcurrencyGroup

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

TestCreateCommitStatus

fix: don't duplicate commit status records on workflows with empty name (#10678)

2026-01-02 19:02:10 +01:00

TestExpandLocalReusableWorkflows

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

TestGetSecretsOfJob

feat: support jobs.<job_id>.secrets with reusable workflow expansion (#10627)

2025-12-30 17:33:21 +01:00

TestServiceActions_startTask

fix: a corrupted Forgejo Actions scheduled workflow is disabled (#8942)

2025-08-18 22:45:10 +02:00

TestServicesActions_TransferLingeringLogs

refactor: migrate from lib/pq to jackc/pgx (#10219)

2025-11-30 17:47:45 +01:00

auth_test.go

feat: add OIDC workload identity federation support (#10481)

2026-01-15 03:39:00 +01:00

auth.go

feat: add OIDC workload identity federation support (#10481)

2026-01-15 03:39:00 +01:00

cleanup_test.go

Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)

2025-03-28 22:22:21 +00:00

cleanup.go

feat: auto cleanup of offline runners (#7803)

2025-06-08 00:13:37 +02:00

clear_tasks.go

Actions Done Notification (#7491)

2025-04-24 15:15:24 +00:00

commit_status_test.go

fix: retain Forgejo Action's commit_status entries with distinct descriptions (#10696)

2026-01-05 14:47:27 +01:00

commit_status.go

fix: retain Forgejo Action's commit_status entries with distinct descriptions (#10696)

2026-01-05 14:47:27 +01:00

context_test.go

feat: support workflow inputs on expanded reusable workflows (#10614)

2025-12-29 15:37:44 +01:00

context.go

feat: add Forgejo server version to runner context (#10642)

2025-12-30 22:39:34 +01:00

init.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

interface.go

feat: add HTTP API endpoint for runner registration (#10677)

2026-01-05 04:59:04 +01:00

job_emitter_test.go

fix: simultaneously experiencing a PreExecutionError and unblocking a different job causes error blocking job emitter queue (#10665)

2026-01-02 17:11:12 +01:00

job_emitter.go

fix: simultaneously experiencing a PreExecutionError and unblocking a different job causes error blocking job emitter queue (#10665)

2026-01-02 17:11:12 +01:00

log_test.go

chore(lint): Add exceptions for dbfs_model and unittest (#10275)

2025-12-09 14:34:06 +01:00

log.go

fix: garbage collect lingering actions logs (#10009)

2025-11-18 18:59:01 +01:00

main_test.go

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

notifier_helper_test.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

notifier_helper.go

fix: prevent intermittent test failures caused by uncancellable tasks (#10713)

2026-01-06 15:34:43 +01:00

notifier.go

feat: github compatability for removing label from issue API (#8831)

2025-08-30 03:29:23 +02:00

rerun_test.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

rerun.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

reusable_workflows_test.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

reusable_workflows.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00

run_test.go

feat(actions): support referencing ${{ needs... }} variables in runs-on (#10308)

2025-12-05 18:14:43 +01:00

run.go

feat: support reusable workflow expansion when with or strategy.matrix contains ${{ needs... }} (#10647)

2025-12-31 19:04:35 +01:00

schedule_tasks_test.go

fix: make concurrency group job cancellation effect runs that are failed (#10863)

2026-01-16 10:54:01 +01:00

schedule_tasks.go

fix: make concurrency group job cancellation effect runs that are failed (#10863)

2026-01-16 10:54:01 +01:00

secret_test.go

feat: support jobs.<job_id>.secrets with reusable workflow expansion (#10627)

2025-12-30 17:33:21 +01:00

secret.go

feat: support jobs.<job_id>.secrets with reusable workflow expansion (#10627)

2025-12-30 17:33:21 +01:00

task_test.go

feat: add OIDC workload identity federation support (#10481)

2026-01-15 03:39:00 +01:00

task.go

feat: add OIDC workload identity federation support (#10481)

2026-01-15 03:39:00 +01:00

trust_test.go

feat: trust management for runs created from a forked pull request

2025-11-06 11:07:38 +01:00

trust.go

feat: trust management for runs created from a forked pull request

2025-11-06 11:07:38 +01:00

variables_test.go

fix: allow Forgejo Actions environment variables starting with CI (#8850)

2025-08-10 22:56:16 +02:00

variables.go

fix: actions variable and secret names validation (#10682)

2026-01-14 04:19:21 +01:00

workflows_test.go

Update module code.forgejo.org/forgejo/runner/v11 to v12 (forgejo) (#10213)

2025-11-23 15:58:57 +01:00

workflows.go

feat: expand reusable workflow calls into their inner jobs (#10525)

2025-12-24 20:47:21 +01:00