Earl Warren
71439965d6
CancelRun Cancels all the jobs of a given run. It is very similar to the less generic web/repo/actions/view.go with two differences: - It updates NeedApproval - The commit status are created within the transaction It is also very similar to cancelJobsForRun in services/actions/schedule_tasks.go Keeping those DRY would require a small refactor that does not feel necessary at this moment. ApproveRun Approves all the jobs of a given run.
105 lines
5.0 KiB
Go
105 lines
5.0 KiB
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package actions
|
|
|
|
import (
|
|
"testing"
|
|
|
|
actions_model "forgejo.org/models/actions"
|
|
"forgejo.org/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestActions_CancelOrApproveRun(t *testing.T) {
|
|
t.Run("run, job and task Running changes to run, job and task Cancelled", func(t *testing.T) {
|
|
defer unittest.OverrideFixtures("services/actions/TestActions_CancelOrApproveRun")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
taskID := int64(711900)
|
|
task := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: taskID})
|
|
require.Equal(t, actions_model.StatusRunning.String(), task.Status.String())
|
|
job := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: task.JobID})
|
|
require.Equal(t, actions_model.StatusRunning.String(), job.Status.String())
|
|
require.Zero(t, job.Stopped)
|
|
run := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
require.Equal(t, actions_model.StatusRunning.String(), run.Status.String())
|
|
|
|
require.NoError(t, CancelRun(t.Context(), run))
|
|
|
|
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
assert.Equal(t, actions_model.StatusCancelled.String(), run.Status.String())
|
|
job = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: task.JobID})
|
|
assert.Equal(t, actions_model.StatusCancelled.String(), job.Status.String())
|
|
assert.NotZero(t, job.Stopped)
|
|
task = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: taskID})
|
|
require.Equal(t, actions_model.StatusCancelled.String(), task.Status.String())
|
|
})
|
|
|
|
t.Run("run Running, job and task Success changes to run Cancelled", func(t *testing.T) {
|
|
defer unittest.OverrideFixtures("services/actions/TestActions_CancelOrApproveRun")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
taskID := int64(710900)
|
|
task := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: taskID})
|
|
require.Equal(t, actions_model.StatusSuccess.String(), task.Status.String())
|
|
job := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: task.JobID})
|
|
require.Equal(t, actions_model.StatusSuccess.String(), job.Status.String())
|
|
run := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
require.Equal(t, actions_model.StatusRunning.String(), run.Status.String())
|
|
|
|
require.NoError(t, CancelRun(t.Context(), run))
|
|
|
|
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
assert.Equal(t, actions_model.StatusCancelled.String(), run.Status.String())
|
|
job = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: task.JobID})
|
|
assert.Equal(t, actions_model.StatusSuccess, job.Status)
|
|
task = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: taskID})
|
|
require.Equal(t, actions_model.StatusSuccess, task.Status)
|
|
})
|
|
|
|
t.Run("run Waiting and job Blocked for Approval changes to run and job Cancelled", func(t *testing.T) {
|
|
defer unittest.OverrideFixtures("services/actions/TestActions_CancelOrApproveRun")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
jobID := int64(10800)
|
|
job := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: jobID})
|
|
require.Equal(t, actions_model.StatusBlocked.String(), job.Status.String())
|
|
run := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
require.Equal(t, actions_model.StatusWaiting.String(), run.Status.String())
|
|
require.True(t, run.NeedApproval)
|
|
|
|
require.NoError(t, CancelRun(t.Context(), run))
|
|
|
|
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
assert.Equal(t, actions_model.StatusCancelled.String(), run.Status.String())
|
|
assert.False(t, run.NeedApproval)
|
|
job = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: jobID})
|
|
assert.Equal(t, actions_model.StatusCancelled, job.Status)
|
|
})
|
|
|
|
t.Run("run Waiting and job Blocked for Approval changes to job Waiting", func(t *testing.T) {
|
|
defer unittest.OverrideFixtures("services/actions/TestActions_CancelOrApproveRun")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
jobID := int64(10800)
|
|
job := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: jobID})
|
|
require.Equal(t, actions_model.StatusBlocked.String(), job.Status.String())
|
|
run := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
require.Equal(t, actions_model.StatusWaiting.String(), run.Status.String())
|
|
require.True(t, run.NeedApproval)
|
|
|
|
doerID := int64(30)
|
|
require.NoError(t, ApproveRun(t.Context(), run, doerID))
|
|
|
|
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: job.RunID})
|
|
assert.Equal(t, actions_model.StatusWaiting.String(), run.Status.String())
|
|
assert.False(t, run.NeedApproval)
|
|
assert.Equal(t, doerID, run.ApprovedBy)
|
|
job = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: jobID})
|
|
assert.Equal(t, actions_model.StatusWaiting, job.Status)
|
|
})
|
|
}
|