limiting-factorandGusted 851356577c chore: do not leak global repository unit defaults (#11470) ...

The [test disabling the issue unit][0] took care of [reseting the disabled units][1]. However, it overlooked that calling [`LoadUnitConfig`][2] also has a [side effect on `DefaultRepoUnits`][3]. It happens when [`validateDefaultRepoUnits` has a side effect][4] on the array backing the slice, when it is [not recreated][5]. As a result the issue unit is disabled for all tests that run after this one.

The subtle side effect is harmless because it only happens in tests, the `LoadUnitConfig` is otherwise only called once. For clarity `LoadUnitConfig` is modified to clone the unit array being validated so that the returned slice is never backed by the same array as the argument.

As the global variables used for repository units should be saved and restored as a whole, a dedicated test function (`SaveUnits`) is provided to be used by both integration tests and unit tests. The test of the unit model is refactored to be a blackbox test in order to avoid an import cycle.

[0]: https://codeberg.org/forgejo/forgejo/src/commit/cce5f868cec11830d19126b90c659772708cd323/tests/integration/repo_settings_test.go#L258
[1]: https://codeberg.org/forgejo/forgejo/src/commit/cce5f868cec11830d19126b90c659772708cd323/tests/integration/repo_settings_test.go#L253
[2]: https://codeberg.org/forgejo/forgejo/src/commit/cce5f868cec11830d19126b90c659772708cd323/models/unit/unit.go#L171
[3]: https://codeberg.org/forgejo/forgejo/src/commit/cce5f868cec11830d19126b90c659772708cd323/models/unit/unit.go#L182
[4]: https://codeberg.org/forgejo/forgejo/src/commit/cce5f868cec11830d19126b90c659772708cd323/models/unit/unit.go#L162
[5]: https://codeberg.org/forgejo/forgejo/src/commit/cce5f868cec11830d19126b90c659772708cd323/models/unit/unit.go#L148

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11470
Reviewed-by: Ellen Εμιλία Άννα Zscheile <fogti@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: limiting-factor <limiting-factor@posteo.com>
Co-committed-by: limiting-factor <limiting-factor@posteo.com>

2026-03-07 02:03:22 +01:00

..

actions

fix: allow Actions runner to recover tasks lost during fetching from intermittent errors (#11401)

2026-02-22 23:24:38 +01:00

activities

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

admin

feat: cache derived keys for faster keying (#10114)

2025-11-16 14:29:14 +01:00

asymkey

chore: fix typos throughout the codebase (#10753)

2026-01-26 22:57:33 +01:00

auth

feat: backend DB model for fine-grained repo access tokens

2026-02-27 17:17:29 +01:00

avatars

feat(perf): remove unused size url parameter for local avatars (#10932)

2026-01-20 04:59:15 +01:00

db

feat(activitypub): use structure @PreferredUsername@host.tld:port for actors (#9254)

2026-01-30 23:45:11 +01:00

dbfs

fix: garbage collect lingering actions logs (#10009)

2025-11-18 18:59:01 +01:00

fixtures

fix(models): deduplicate project sorting values and add unique constraints (#11334)

2026-02-27 16:25:20 +01:00

forgefed

log instrumentation & test package (#10371)

2025-12-09 15:37:50 +01:00

forgejo/semver

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

forgejo_migrations

feat: backend DB model for fine-grained repo access tokens

2026-02-27 17:17:29 +01:00

forgejo_migrations_legacy

fix: normalize secrets consistently, display accurate help (#11052)

2026-02-09 17:02:18 +01:00

git

refactor: replace Value() from Option[T] with Get() & ValueOrZeroValue() (#11218)

2026-02-10 16:41:21 +01:00

gitea_migrations

fix(models): deduplicate project sorting values and add unique constraints (#11334)

2026-02-27 16:25:20 +01:00

issues

chore: handle error types consistently (#9873)

2026-03-06 00:48:06 +01:00

moderation

feat: render a link to poster profile next to the ID within shadow copy details (#10194)

2025-12-09 15:19:10 +01:00

organization

feat: implement fine-grained access tokens in /teams/{id}/repos

2026-03-01 10:54:43 -07:00

packages

refactor: replace Value() from Option[T] with Get() & ValueOrZeroValue() (#11218)

2026-02-10 16:41:21 +01:00

perm

feat: add GetUserRepoPermissionWithReducer

2026-02-27 17:17:29 +01:00

project

fix(models): deduplicate project sorting values and add unique constraints (#11334)

2026-02-27 16:25:20 +01:00

pull

fix: do not ignore automerge while a PR is checking for conflicts (#8189)

2025-06-17 10:58:07 +02:00

quota

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

repo

feat: add authorization reducer support to SearchRepoOptions

2026-03-01 10:54:43 -07:00

secret

fix: normalize secrets consistently, display accurate help (#11052)

2026-02-09 17:02:18 +01:00

shared/types

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

system

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

unit

chore: do not leak global repository unit defaults (#11470)

2026-03-07 02:03:22 +01:00

unittest

fix: prevent panic on gitlab import (releases/issues) (#11282)

2026-03-03 21:36:14 +01:00

user

fix: UserTypeRemoteUser is an eligible organization member (#11326)

2026-02-17 02:39:46 +01:00

webhook

refactor: replace Value() from Option[T] with Get() & ValueOrZeroValue() (#11218)

2026-02-10 16:41:21 +01:00

error.go

fix: don't allow credentials in migrate/push mirror URL

2025-08-30 08:07:23 +02:00

main_test.go

chore: move all test blank imports in a single package (#10662)

2026-01-02 05:32:32 +01:00

org_team_test.go

Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)

2025-03-28 22:22:21 +00:00

org_team.go

chore: fix typos throughout the codebase (#10753)

2026-01-26 22:57:33 +01:00

org_test.go

Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)

2025-03-28 22:22:21 +00:00

org.go

chore: branding import path (#7337)

2025-03-27 19:40:14 +00:00

repo_test.go

Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)

2025-03-28 22:22:21 +00:00

repo_transfer_test.go

chore: fix typos throughout the codebase (#10753)

2026-01-26 22:57:33 +01:00

repo_transfer.go

chore: fix typos throughout the codebase (#10753)

2026-01-26 22:57:33 +01:00

repo.go

fix: possible cause of invalid issue counts; cache invalidation occurs before a active transaction is committed (#10130)

2025-11-17 01:07:29 +01:00